Skip to content

Fix scoped context and conflicting properties#263

Open
mielvds wants to merge 11 commits into
masterfrom
204-conflicting-value-override
Open

Fix scoped context and conflicting properties#263
mielvds wants to merge 11 commits into
masterfrom
204-conflicting-value-override

Conversation

@mielvds
Copy link
Copy Markdown
Collaborator

@mielvds mielvds commented May 12, 2026 •
edited
Loading

This PR fixes #204 and two related tests in the test-suite:

https://w3c.github.io/json-ld-api/tests/toRdf-manifest.html#tc037

Nesting terms may have property-scoped contexts defined.

https://w3c.github.io/json-ld-api/tests/toRdf-manifest.html#tc038

Nesting terms may have property-scoped contexts defined.

The issue was that @nest keys were delayed for later expansion before their property-scoped context was applied. This fix first gets the scoped @context from the @nest term and stores this property-scoped context with the key. The delayed nested object expansion then later uses that property-scoped context, so for

{
  "@context": {
    "@vocab": "http://example.org/vocab#",
    "p1": {
      "@id": "@nest",
      "@context": {
        "p2": "http://example.org/ns#P2"
      }
    }
  },
  "p1": {
    "p2": "foo"
  }
}

"p2" expands to http://example.org/ns#P2 instead of falling back to outer @vocab.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
lib/pyld
   canon.py218498%27, 180, 565–566
   context_resolver.py102892%70, 129, 143, 189, 195–197, 221
   iri_resolver.py141398%307–308, 318
   jsonld.py244516493%274–278, 359, 396, 401, 411, 428–443, 479–480, 522, 530, 550, 558–559, 667–672, 752–753, 768–769, 829–834, 859–860, 875–876, 886–887, 913, 954, 964, 970–974, 985–986, 1019, 1028, 1035, 1100, 1123, 1145–1147, 1157–1160, 1175, 1198, 1210–1213, 1305, 1317–1320, 1340, 1369, 1402, 1406, 1443, 1486, 1505–1508, 1517, 1566, 1669–1676, 1703–1705, 1731–1734, 1910, 1948, 2356, 2365–2372, 2464, 2491, 2514, 2523, 3099, 3152, 3155, 3218, 3303, 3337, 3345, 3623, 3628, 3630, 3679, 3817–3821, 3887, 3924, 3987, 4222, 4510, 4644, 4678, 4707–4710, 4736–4737, 4920, 4984, 5011, 5085, 5087, 5105, 5203, 5252, 5484, 5486, 5525, 5527, 5536, 5675, 5803, 5890, 6010–6024, 6086, 6088, 6156, 6369, 6375–6379, 6418, 6421, 6511–6512, 6521
lib/pyld/documentloader
   aiohttp.py712269%29–39, 68, 74, 86, 98–106, 118–121, 138, 153–156
   requests.py49590%54, 68, 80–88
TOTAL321420694% 

Tests Skipped Failures Errors Time
1686 50 💤 0 ❌ 0 🔥 2m 15s ⏱️

@mielvds mielvds mentioned this pull request May 12, 2026
Open
@mielvds mielvds marked this pull request as ready for review May 12, 2026 19:30
@PonteIneptique
Copy link
Copy Markdown

PonteIneptique commented May 12, 2026

The tests correspond to the initial issue 👍 Thanks for your work !

@anatoly-scherbakov
Copy link
Copy Markdown
Collaborator

anatoly-scherbakov commented May 14, 2026

The changes might alter behavior in regard to nested contexts. I just pushed a test to this branch which aims to demonstrate that. I am sorry for pushing for a branch that's not mine, I will rather create a new, derived branch the next time @mielvds - I hope this won't create too much of an inconvenience.

@mielvds mielvds force-pushed the 204-conflicting-value-override branch from 2e9a89e to 7aa493a Compare May 18, 2026 08:57
@mielvds
Copy link
Copy Markdown
Collaborator Author

mielvds commented May 18, 2026 •
edited
Loading

The changes might alter behavior in regard to nested contexts. I just pushed a test to this branch which aims to demonstrate that. I am sorry for pushing for a branch that's not mine, I will rather create a new, derived branch the next time @mielvds - I hope this won't create too much of an inconvenience.

Not at all @anatoly-scherbakov! Could you propagate this test to the JSON-LD test-suite? 🙏

I moved some of the docstring around to where it fits best. Most of it made more sense in the actual code. I added an internal method _prepare_nested_context that handles these complex cases, which is basically moving the logic for finding the active type-scoped context from _expand() and calling it in the loop that I included in the original fix.

@anatoly-scherbakov anatoly-scherbakov mentioned this pull request May 18, 2026
Open
@anatoly-scherbakov
Copy link
Copy Markdown
Collaborator

anatoly-scherbakov commented May 18, 2026

Propagated the nested scoped-context regression to the JSON-LD API test suite: w3c/json-ld-api#689

@mielvds mielvds force-pushed the 204-conflicting-value-override branch from e82e5a1 to 3d42075 Compare May 19, 2026 04:43
@mielvds
Copy link
Copy Markdown
Collaborator Author

mielvds commented May 19, 2026

@anatoly-scherbakov thanks! I did some final cleanup. It could still use a (minor) code review though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidlehn davidlehn Awaiting requested review from davidlehn

@BigBlueHat BigBlueHat Awaiting requested review from BigBlueHat

@dlongley dlongley Awaiting requested review from dlongley

@anatoly-scherbakov anatoly-scherbakov Awaiting requested review from anatoly-scherbakov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@nested node with own vocab has conflicting value overriden

3 participants

@mielvds @PonteIneptique @anatoly-scherbakov